Skip to content

Feat: wallet disconnect handler - #357

Merged
godamongstmen897 merged 123 commits into
Goldii-locks:mainfrom
She-ge:feat/234-wallet-disconnect-timeout-bounds
Aug 31, 2026
Merged

Feat: wallet disconnect handler#357
godamongstmen897 merged 123 commits into
Goldii-locks:mainfrom
She-ge:feat/234-wallet-disconnect-timeout-bounds

Conversation

@She-ge

@She-ge She-ge commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

closes #234

vicajohn and others added 24 commits August 27, 2026 06:26
- Replace hardcoded empty message with EmptyStateCard component
- Display briefcase icon for job-related context
- Show descriptive title and explanation text
- Include role badges (Client, Freelancer, Arbiter) showing available participation options
- Add comprehensive test coverage with 16 test cases
- Ensure proper accessibility with region landmarks and aria-labels
- Validates placeholder display under empty data states
…, desktop

- Add responsive padding and spacing (px-3 sm:px-6) for mobile-first approach
- Implement responsive typography scaling (text-xl sm:text-2xl md:text-3xl)
- Stack layout vertically on mobile, horizontal on tablet/desktop
- Apply responsive grid layouts (grid-cols-1 sm:grid-cols-2 lg:grid-cols-3)
- Make search form full-width on mobile, inline on tablet+
- Add responsive gaps and margins throughout
- Implement horizontal overflow handling for pagination on mobile
- Reduce button padding and font sizes on mobile viewports
- Add comprehensive responsive design test suite with 20 test cases
- Validate layout at mobile (< 640px), tablet (640-1024px), desktop (> 1024px)
…yling

- Add focus-visible ring-2 styling on all interactive elements (indigo-500)
- Implement hover state transitions with smooth animations (transition-all duration-200)
- Add active state styling for button press feedback
- Style disabled buttons with opacity-50 and cursor-not-allowed
- Prevent hover effects on disabled buttons (disabled:hover:bg-gray-900)
- Apply ring-offset for focus states on dark background (ring-offset-gray-950)
- Use inset focus ring on job expand buttons for better UX
- Add focus-visible:outline-none to remove browser defaults
- Implement smooth transitions on all state changes
- Add comprehensive test suite with 25 test cases validating:
  - Search input focus and hover states
  - Search button focus, hover, and active states
  - Role filter button states and transitions
  - Job expand button interactive states
  - Pagination button states and disabled styling
  - Accessibility compliance and transitions
Implements the app dark/light theme toggle as a keyboard-operable,
ARIA-compliant switch (role=switch, aria-checked, aria-label) that
persists the chosen theme to localStorage and applies it to the document
root. Adds React Testing Library tests verifying node rendering,
accessible state, theme application, keyboard operation and persistence.

Closes Goldii-locks#319
Implements the navbar alert bell badge as a keyboard-operable
(role=button) disclosure with ARIA compliance (Goldii-locks#320): accessible name,
aria-haspopup/aria-expanded/aria-controls, aria-live announcement
regions, aria-hidden on decorative glyphs, focus-visible rings and
design-token contrast.

Adds field error indicators and alerts (Goldii-locks#324): validation field configs
render role=alert error text that toggles as validation triggers, wired
via aria-describedby and counted toward the unread badge.

Adds React Testing Library tests covering both requirements.

Closes Goldii-locks#320
Closes Goldii-locks#324
Stack the stat grid and content rows to a single column on mobile,
two on tablet, three on desktop, and use responsive padding/spacing
so LoadingSkeleton scales cleanly at every breakpoint.

Closes Goldii-locks#275
Fade the skeleton in on mount (animate-fade-in) instead of popping in
abruptly, and stagger each placeholder bar's pulse animation-delay so
the loading state reads as a smooth wave rather than a flat blink.

Closes Goldii-locks#278
Replace the bare "No jobs found" line with a reusable EmptyState
component (icon, heading, supporting copy) shown once loading
finishes with zero jobs for the connected wallet.

Closes Goldii-locks#276
… mobile

Cap the skeleton's height on small viewports and let it scroll
internally (overscroll-contain) instead of pushing surrounding
controls off-screen, while keeping the wrapper free of fixed/absolute
positioning so it never traps taps on other elements.

Closes Goldii-locks#279
@drips-wave

drips-wave Bot commented Aug 29, 2026

Copy link
Copy Markdown

@She-ge Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

jeremiahelishaa180-commits and others added 5 commits August 29, 2026 18:21
Closes Goldii-locks#240, Goldii-locks#238, Goldii-locks#236, Goldii-locks#332.

wallet_disconnect_handler (Goldii-locks#240, Goldii-locks#238, Goldii-locks#236)
- Goldii-locks#240 Gas estimation warnings: checkDisconnectSimulationFeeWarning inspects
  a Soroban simulation result and flags fees above the 1_000_000 stroop
  (0.1 XLM) bound, plus simulation errors and non-finite fee estimates.
  Simulation errors take precedence over the fee check, since a failed
  simulation's reported fee is not trustworthy. Surfaced by
  WalletDisconnectGasWarningBanner.
- Goldii-locks#238 Loading spinner: a counter-based loader lifecycle
  (start/end/reset/subscribe/withWalletDisconnectLoader) so overlapping
  disconnects do not hide the overlay early, clamped at zero so an
  unbalanced end cannot wedge it open. disconnectWalletWithCheck now runs
  entirely inside the lifecycle, so the spinner clears on every exit path
  (success, missing wallet, throw). Surfaced by
  WalletDisconnectLoaderOverlay.
- Goldii-locks#236 Network mismatch: checkDisconnectNetworkMatch compares the wallet
  chain against the app chain, normalising bare labels, the public/test
  aliases, and full Stellar passphrases, since wallets report them
  interchangeably. An unrecognised network is reported as a mismatch rather
  than silently ignored. Surfaced by WalletDisconnectNetworkWarningBar.

dispute_raise_modal (Goldii-locks#332)
- The module did not exist; added app/lib/dispute_raise_modal.ts and
  DisputeRaiseModal alongside it. Sizing is mobile-first: a full-bleed
  bottom sheet with stacked full-width actions on phones, a centered
  sm:max-w-lg dialog on tablets, and a lg:max-w-2xl panel on desktop. The
  summary grid collapses to one column below sm: and long addresses wrap,
  so nothing forces horizontal scroll at 375/414px. Touch targets meet the
  44px minimum used elsewhere in the repo.
- useDisputeViewport uses useSyncExternalStore rather than an effect plus
  setState, avoiding the cascading render the react-hooks
  set-state-in-effect rule targets.

Tests: 4 new files, 204 cases covering fee bounds and simulation errors,
spinner toggling on start/end across every exit path, network mismatch
detection and warning-bar rendering, and modal layout at 320-1920px
including live resize. Type-check and lint clean.

Pre-existing failures unchanged and unrelated: 4 cases in
freighter_multisig_hook.test.ts (invalid XDR fixtures) and 2 files that
cannot collect due to a @stellar/freighter-api CJS/ESM interop error via
WalletContext. Both reproduce on a clean checkout.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…oldii-locks#216)

Build chain network checks in a new TransactionSigner component to alert
users when their wallet network does not match the app (e.g. Mainnet vs
Testnet). Includes network mismatch warning bar, sign button disabled on
mismatch, and comprehensive unit/component/integration tests.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
godamongstmen897 and others added 26 commits August 31, 2026 13:35
The branch was pushed with a botched conflict resolution: the `>>>>>>>`
markers were stripped but the branch-name lines and both sides of each
conflict were left in place. That left four stray
`Write-React-Testing-Library-assertions-...-Goldii-locks#242-FIX` lines, a duplicate
`@stellar/stellar-sdk` import block, a second `parseMessage` useMemo in
SignatureTimeoutAlert, and a duplicate `server` key in vitest.config.mts.

Resolved by taking main for the five files the branch only touched
incidentally -- main already carries the equivalent, deduplicated work
(the same parseMessage useMemo derivation and the same freighter-api
inline config the branch was re-adding).

The branch's actual deliverable for Goldii-locks#242 is kept intact:
WALLET_DISCONNECT_HANDLER_TESTS.md and the 851-line
wallet_disconnect_handler.component.test.ts.

lint 0 errors / tsc 0 errors / 1776 tests passing / build OK
…Testing-Library-assertions-for-wallet-disconnect-handler-#242-FIX

Write React Testing Library assertions for wallet disconnect handler …
…ns target

The two design-token cases rendered WalletSelectorModal with its default
props, where `errorMessage` defaults to null and `activeAddress` defaults
to null. Both surfaces under test are gated on those props, so
`wallet-selector-error-message` and `wallet-selector-connected-badge`
were never in the tree and the queries threw.

Passed an errorMessage to the first case and an activeAddress to the
second. The component's design tokens were already correct -- only the
test setup needed the props.

lint 0 errors / tsc 0 errors / 1778 tests passing / build OK
…e-modal-design-tokens

Feat: Dispute Raise ModaL
…n tokens

The suite hardcoded the raw Tailwind palette LoadingSkeleton used when
the branch was written. main has since migrated the component to
semantic design tokens, so the class assertions and the querySelector
calls that locate the cards no longer matched anything.

Remapped throughout:
  bg-gray-900                  -> bg-surface-card
  bg-gray-800 (bars, stat card)-> bg-surface-field
  bg-gray-700 (stat placehold.)-> bg-border-subtle
  border-gray-800              -> border-border-strong

Worth noting three cases were passing vacuously: the stat- and
milestone-card selectors returned empty NodeLists, so their forEach
assertion bodies never ran. With the selectors fixed they now iterate
and pass for real -- 54 of 54 in this file, up from 49.

lint 0 errors / tsc 0 errors / 1832 tests passing / build OK
…ng-spinner-skeleton

test: Add React Testing Library tests for LoadingSkeleton and ButtonSpinner (Goldii-locks#282)
… design tokens

The branch was cut before main migrated LoadingSkeleton to semantic
design tokens and added the skeleton-* test ids, so its side of the
conflict still carried bg-gray-*/no-testid markup. Resolved by applying
the branch's responsive layout on top of main's tokenised markup rather
than taking either side whole.

Two adjustments to keep the sibling suites passing:

- The branch's new test ids (loading-skeleton-card/-stats/-rows) name
  elements that already carry ids on main (skeleton-container,
  skeleton-stats-grid, skeleton-milestones). An element can only hold
  one data-testid, so the test now queries main's names -- every
  assertion is unchanged.

- Placeholder bars are expressed desktop-first (w-32 max-sm:w-24) rather
  than mobile-first (w-24 sm:w-32). Same computed result at both
  breakpoints, but it keeps the fixed widths on the element so the
  structural selectors in loading-spinner-skeleton.test.tsx still match.

The two card-padding assertions there did have to move to the responsive
class (p-6 -> sm:p-6, space-y-6 -> sm:space-y-6), since the branch
deliberately makes those breakpoint-dependent.

lint 0 errors / tsc 0 errors / 1841 tests passing / build OK
…skeleton-responsive-275

feat(loading-skeleton): responsive sizing across mobile/tablet/desktop
Same situation as Goldii-locks#349: the branch predates the design-token migration,
so its side of the LoadingSkeleton conflict still carried the old
bg-gray-* markup. Applied the branch's animation work on top of main's
current component instead of taking either side whole -- animate-fade-in
on the root, and animate-pulse plus the staggered
[animation-delay:...] utilities on the three stat cards (100/175/250ms)
and two milestone rows (325/400ms).

The branch's test ids (loading-skeleton-card/-stat-N/-row-N) name
elements that already carry ids on main, so the test queries main's
names (skeleton-container, skeleton-stat-card-N,
skeleton-milestone-card-N). Assertions and delay values are unchanged.

Delays are written as literal class names rather than interpolated,
since Tailwind only emits CSS for classes it can see statically.

lint 0 errors / tsc 0 errors / 1847 tests passing / build OK
…skeleton-animations-278

feat(loading-skeleton): CSS micro-animations on mount and pulse stagger
Same conflict shape as Goldii-locks#349 and Goldii-locks#351 -- the branch predates the
design-token migration, so its side of LoadingSkeleton still carried the
old bg-gray-* markup. Applied the branch's mobile work on top of main's
current component: a max-h-[70vh] sm:max-h-none overflow-y-auto
overscroll-contain wrapper between the status root and the card, so the
skeleton scrolls internally on small viewports rather than pushing the
surrounding controls off-screen.

The wrapper sits outside the card, so the card's first child is still
the header row that Goldii-locks#349's responsive assertions rely on.

lint 0 errors / tsc 0 errors / 1852 tests passing / build OK
…skeleton-mobile-279

feat(loading-skeleton): constrain height and preserve clickability on mobile
Same conflict shape as the other LoadingSkeleton branches -- this one
predates the design-token migration, the responsive sizing, the stagger
animations and the mobile wrapper, so its side still carried the old
markup. Applied the branch's props to main's current component rather
than taking either side whole: interactive swaps the root to
role="button" and adds the hover/focus-visible treatment, disabled adds
opacity-50 cursor-not-allowed and blocks click and key handling.

The interactive styling is the branch's own gray-* palette, which is
fine here: it is only emitted when interactive is set, and the
design-token suite renders the default (non-interactive) skeleton, so
its "no hardcoded gray-*" assertion still holds.

One correction to the branch's test -- it asserted the loading label as
"Loading job data..." with three ASCII dots, but the component has
always used a U+2026 ellipsis, so the query could never match. Aligned
the assertion to the character the component renders.

ButtonSpinner takes the branch's version as-is (disabled prop,
transition classes, button-spinner test id).

lint 0 errors / tsc 0 errors / 1858 tests passing / build OK
…er-skeleton-states-274

feat(ui): add interactive hover focus and disabled states to loading …
…he row animations

Two conflicts in app/dashboard/page.tsx, both resolved by taking each
side's contribution rather than picking one:

- Job row button: the branch's responsive padding (px-3 sm:px-5 py-3
  sm:py-4) with main's interaction feedback (transition-colors
  duration-150, active:scale-[0.99], active:bg-gray-800/70). The
  branch's own assertion only covers px-3/sm:px-5, and nothing asserts
  the active: classes, so keeping both loses nothing.

- Expanded panel: the branch's responsive spacing and border-t, plus
  main's data-testid="dashboard-expanded-panel" and animate-fade-in.
  The branch's side had dropped the test id, which
  dashboard-list-animations.test.tsx queries.

lint 0 errors / tsc 0 errors / 1878 tests passing / build OK
…onsive-design

Feat/dashboard responsive design
…classes

One conflict on the job row button in app/dashboard/page.tsx. Both
sides styled the same element, so the resolution keeps every class
either side contributed:

  responsive padding      px-3 sm:px-5 py-3 sm:py-4   (from Goldii-locks#304)
  press feedback          active:scale-[0.99]         (from main)
  focus ring              focus-visible:ring-2/-inset/-indigo-500 (this branch)

Transition widened to transition-all duration-200 (this branch's value)
rather than transition-colors -- the branch adds a focus ring, and
main's side adds a scale, neither of which transition-colors animates.

lint 0 errors / tsc 0 errors / 1903 tests passing / build OK
…ractive-states

Feat/dashboard interactive states
…k-switcher-mobile-nav

fix(Goldii-locks#316): Handle mobile viewports navigation styling in dark_mode_switcher
… semantics

Two conflicts in app/dashboard/page.tsx, both resolved by keeping every
attribute either side contributed:

- Error alert: the branch's styled box and aria-live="assertive" plus
  main's data-testid="dashboard-error-alert" and animate-shake.
- Expanded panel: the branch's id/role="region"/aria-label plus main's
  data-testid="dashboard-expanded-panel" and animate-fade-in.

Beyond the conflicts, this branch changes the accessible names and roles
of controls that sibling suites already query, and its copy of
dashboard-interactive-states.test.tsx is identical to main's -- so those
queries were never updated to match. Retargeted them:

  filter controls   role=button -> role=tab (the branch wraps them in a
                    tablist), aria-pressed -> aria-selected
  search submit     name "Search" -> "Submit search query"
  pagination        name "Previous"/"Next" -> /Previous page/i, /Next page/i

Touched dashboard-interactive-states, dashboard-responsive and
loading-skeleton-mobile. Every assertion still checks what it did
before -- only the queries locating the elements changed.

lint 0 errors / tsc 0 errors / 1945 tests passing / build OK
…ssibility-compliance

Feat/dashboard accessibility compliance
…he timeout call

git aligned two unrelated function bodies here: the branch's rewritten
disconnectWalletWithCheck against main's generic
withWalletDisconnectLoader, so the raw conflict would have replaced the
loader's body with disconnect logic referencing disconnectFn, options
and walletId -- none of which are in that scope.

Resolved by putting each change where it belongs:

- withWalletDisconnectLoader keeps main's body.
- disconnectWalletWithCheck routes through the branch's new
  runWalletDisconnectWithTimeout helper, still inside main's
  withWalletDisconnectLoader wrapper.

The branch predates the loader lifecycle work (Goldii-locks#238), which is why its
side had dropped that wrapper -- keeping both preserves the timeout
bounds this PR is for and the overlay behaviour already on main.

lint 0 errors / tsc 0 errors / 1948 tests passing / build OK
@godamongstmen897
godamongstmen897 merged commit a2bddfd into Goldii-locks:main Aug 31, 2026
1 check passed
godamongstmen897 added a commit to She-ge/escrow-frontend that referenced this pull request Aug 31, 2026
No textual conflict once Goldii-locks#357 (this branch's parent) landed on main --
GitHub's cached mergeability was stale and its update-branch call
reported a conflict that a local three-way merge does not reproduce.
Merging main in here refreshes the head so CI runs against current main.

lint 0 errors / tsc 0 errors / 1949 tests passing / build OK
godamongstmen897 added a commit to DavisVT/escrow-frontend that referenced this pull request Aug 31, 2026
…eachable

Three conflicts in wallet_disconnect_handler.ts, all from this branch
predating the loader lifecycle work (Goldii-locks#238) and the timeout bounds (Goldii-locks#357):

- Doc comment: kept both notes.
- "Not installed" branch: main's structure (it now sits inside the
  withWalletDisconnectLoader closure, hence the deeper indent) plus this
  branch's removeActiveKey call.
- Third hunk was git aligning this branch's disconnectWalletWithCheck
  body onto main's generic withWalletDisconnectLoader again, as in Goldii-locks#357.
  Kept main's loader body and applied the branch's success-path
  removeActiveKey where it belongs, after the timeout-wrapped disconnect.

Also fixed a contradiction inside the branch's own code:
isValidSerializedPayload looped over every entry and rejected the whole
payload if any one was invalid, which made the per-entry
sanitizeWalletActiveKey/filter below it unreachable. Its own test
"handles invalid active keys array by sanitizing" expects one good entry
out of three to survive, so the validator now checks the envelope
(record, known version, activeKeys array) and leaves entry validity to
the sanitize step.

That alone would have silently dropped bad entries, which the sibling
test "rejects session state with missing required fields" requires a warn
for, so rehydrate now logs REHYDRATE DROPPED ENTRIES when the sanitized
count is short. Partial corruption is both survivable and visible.

lint 0 errors / tsc 0 errors / 1975 tests passing / build OK
godamongstmen897 added a commit to udeachudivine-spec/escrow-frontend that referenced this pull request Aug 31, 2026
… suites

Navbar (4 conflicts): kept main's design tokens and the props its side
passes (isConnecting, providerName, networkMismatch) -- the branch's
side replaced that block with a status="connected" badge and dropped
those three -- while taking the branch's mobile fixes: relative z-10,
px-4 sm:px-6, py-3 sm:py-4, gap-2, flex-wrap, min-w-0 and shrink-0 on
the brand link and badge. That is the actual Goldii-locks#259 deliverable.

wallet_disconnect_handler (3 conflicts): the third was git aligning the
branch's disconnectWalletWithCheck body onto withWalletDisconnectLoader
again, as in Goldii-locks#357 and Goldii-locks#371. Kept main's loader body; the branch's
pendingTx warning runs before the loader is entered, and its success log
sits on the real success path. Both Goldii-locks#357's options and this branch's
pendingTx wanted the 4th parameter, so options stays 4th and pendingTx
is 5th; the one call site passing it now passes undefined for options.

The logging levels were a genuine three-way conflict. This branch (Goldii-locks#241)
moves failures to console.error carrying the Error so the stack
survives, and adds a success log. Goldii-locks#364's component suite, already on
main, asserted the old behaviour: warn on failure, and complete silence
on success.

Settled as:
  success                    console.info   (informational -- keeps
                                            Goldii-locks#364's "no warn, no error"
                                            assertion true)
  disconnect failure         console.error(tag, err)
  availability check failure console.error(tag, err)
  pending transaction        console.warn
  wallet not installed       console.warn

Updated the assertions that described the superseded levels: four
failure checks in wallet_disconnect_handler.component.test.ts moved from
warnSpy to errorSpy, and this branch's success/pending-tx counts now
account for console.info. No assertion changed what it verifies.

lint 0 errors / tsc 0 errors / 1996 tests passing / build OK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce transaction signature time limit bounds in wallet_disconnect_handler